Respect the returnToLobby flag #3051
Merged
+45
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
requested changes
Mar 5, 2025
2bb5b02 refactored the end of the GroupCallView render function to not use any early returns, and clumsily failed to account for the fall-through case that makes returnToLobby work (as opposed to sitting on a blank screen).
If returnToLobby is enabled then we obviously want to keep the widget open once the user leaves the call.
robintown
force-pushed
the
robin/return-to-lobby
branch
from
4530577 to
28c45c6
Compare
hughns
approved these changes
Mar 5, 2025
toger5
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits for the details, but what happened is #3021 regressed our handling of the
returnToLobbyURL parameter. This was causing video rooms on develop.element.io to show a blank screen after leaving the call rather than returning to the lobby view.Will need backporting to
release-v0.7.2because this implies a behavior change in the 'close' action that element-hq/element-web#29254 would adapt to.