Skip to content

Set ratchetWindowSize to > 0 enable rachet compatibility. #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Set ratchetWindowSize to > 0 enable rachet compatibility. #3224

merged 1 commit into from
Apr 23, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 22, 2025

This is a subset of: #3214

It will allow us to be compatible with any version of EC that does ratcheting.

@toger5 toger5 requested a review from a team as a code owner April 22, 2025 16:10
@toger5 toger5 requested a review from robintown April 22, 2025 16:10
@toger5 toger5 mentioned this pull request Apr 22, 2025
Merged
@toger5 toger5 added PR-Improvement Release note category. A PR that improves EC's performance or stability. backport-candidate Something that is a candidate for backport to a particular release branch labels Apr 22, 2025
@toger5 toger5 requested a review from BillCarsonFr April 22, 2025 16:13
BillCarsonFr
BillCarsonFr approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. There might be a behavior change regarding how the failureTolerance works and when it will stop trying a bad key, but that's fine?

@toger5 toger5 merged commit a1d6eef into livekit Apr 23, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
backport-candidate Something that is a candidate for backport to a particular release branch PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @BillCarsonFr