Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore macOs room header dragability #1136

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 1, 2023

Fixes #1135

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@germain-gg germain-gg requested a review from a team as a code owner August 1, 2023 15:33
.mx_RoomHeader .mx_E2EIcon,
.mx_RoomHeader .mx_RoomTopic,
.mx_RoomHeader .mx_AccessibleButton {
.mx_RoomHeader .mx_DecoratedRoomAvatar,
Copy link
Member

@t3chguy t3chguy Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text container for the room name in the room header should also be no-drag, like it is on legacy (its within the Accessible Button)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure it needs to be like that.
The new room header is not interactive the same way the old one way, therefore we can allow drag from that element.

In the spirit of moving that pull request forward i've pushed that change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd mean you can't highlight the text which is not good for accessibility

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@germain-gg
Copy link
Contributor Author

Cross posting what I added to #element-dev:matrix.org

IMO we should not use the CSS classes we use for styling in order to set the draggability. It kinda hides intent, maybe using a data attribute or a electron- prefixed css class could help be more explicit and avoid this kind of regressions in the future?

@germain-gg germain-gg requested a review from t3chguy August 2, 2023 06:49
@germain-gg germain-gg enabled auto-merge (squash) August 2, 2023 06:49
@germain-gg germain-gg merged commit 07523ec into develop Aug 2, 2023
@germain-gg germain-gg deleted the germain-gg/fix/1135 branch August 2, 2023 07:05
@germain-gg germain-gg mentioned this pull request Aug 31, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room header icons unclickable
3 participants