-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Story] Render permalinks in the timeline #2342
Comments
While we can implement the pill in the timeline, it would make sense to also do it in the editor if we start working on this already. Thus, either enlarge the scope of this item or create a separate story for editor and put them under one epic. |
https://www.figma.com/design/2qAtUobdikIwVBFHmZcLvb/Permalinks?node-id=215-1917&t=z7tevkUV6nrS3uhE-0 @amshakal could you double check if these design for pills are up to date? For user mentions, we used to show an avatar but later before release it was decided to scrap the avatars entirely and just keep them simple, containing only text, maybe that's what we want to do also for room pills and message pills? |
@americanrefugee if you can also double check since Amsha is not available, these designs are quite old and don't match what we currenlty have for users |
Okay these are likely the designs we want to use for rooms and messages: But let's wait confirmation from @amshakal |
Important: These should also be aligned with room alias permalinks. |
so far I have tested it on EW all the following cases:
Do we want to replicate the same behaviour of EW? |
I do not immediately see any significant and simple improvements to what EW does. Thus, propose to just replicate what it does for sake of consistency. |
Description
As a user, I want to be able to visually identify permalink included in the message rendered in the timeline, so that I can understand that I can click on it, and I can expect that I will be redirected to the correct target. The permalink will render as pills and the link will be replaced by more useful information, like the room name, or the user display name.
Note that some cases may already be implemented in some EX mobile clients.
Figma
Leads
Acceptance criteria
Size estimate
M
Dependencies
Out of scope
Open questions
Questions
Subtasks
Android
iOS
Rust
Bugs
The text was updated successfully, but these errors were encountered: