Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Render permalinks in the timeline #2342

Open
2 of 3 tasks
bmarty opened this issue Mar 13, 2024 · 7 comments
Open
2 of 3 tasks

[Story] Render permalinks in the timeline #2342

bmarty opened this issue Mar 13, 2024 · 7 comments

Comments

@bmarty
Copy link
Member

bmarty commented Mar 13, 2024

Description

As a user, I want to be able to visually identify permalink included in the message rendered in the timeline, so that I can understand that I can click on it, and I can expect that I will be redirected to the correct target. The permalink will render as pills and the link will be replaced by more useful information, like the room name, or the user display name.

  • Permalink for users are rendered correctly on the timeline. Generally permalink for users are for user members, but it can be any matrix.to link for users.
  • Permalink for rooms are rendered correctly on the timeline. Room details have to be retrieved, so that room display name can replace the link. Note that depending on the room state, the room details can be retrieved even if the user is not a member of the room.
  • Permalink for messages are rendered correctly on the timeline. Links to message contain the room Id, so same than for room, it can be possible to retrieve the room details even if the user is not a member of the room.

Note that some cases may already be implemented in some EX mobile clients.

Figma

Leads

Acceptance criteria

  • TBD

Size estimate

M

Dependencies

  • None

Out of scope

  • Permalink auto completion in the editor will happen in a separate story.

Open questions

Questions

Preview Give feedback
No tasks being tracked yet.

Subtasks

Android

Preview Give feedback
  1. T-Task
    bmarty

iOS

Preview Give feedback
  1. T-Task

Rust

Preview Give feedback
No tasks being tracked yet.

Bugs

Preview Give feedback
  1. A-Pills O-Occasional S-Minor T-Defect
    Velin92
@mxandreas
Copy link

While we can implement the pill in the timeline, it would make sense to also do it in the editor if we start working on this already. Thus, either enlarge the scope of this item or create a separate story for editor and put them under one epic.

@Velin92
Copy link
Member

Velin92 commented Feb 14, 2025

https://www.figma.com/design/2qAtUobdikIwVBFHmZcLvb/Permalinks?node-id=215-1917&t=z7tevkUV6nrS3uhE-0 @amshakal could you double check if these design for pills are up to date?

For user mentions, we used to show an avatar but later before release it was decided to scrap the avatars entirely and just keep them simple, containing only text, maybe that's what we want to do also for room pills and message pills?

@Velin92
Copy link
Member

Velin92 commented Feb 14, 2025

https://www.figma.com/design/2qAtUobdikIwVBFHmZcLvb/Permalinks?node-id=215-1917&t=z7tevkUV6nrS3uhE-0 @amshakal could you double check if these design for pills are up to date?

For user mentions, we used to show an avatar but later before release it was decided to scrap the avatars entirely and just keep them simple, containing only text, maybe that's what we want to do also for room pills and message pills?

@americanrefugee if you can also double check since Amsha is not available, these designs are quite old and don't match what we currenlty have for users

@Velin92
Copy link
Member

Velin92 commented Feb 14, 2025

Okay these are likely the designs we want to use for rooms and messages:
https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?t=nS9KuQNz1fwSYTTG-0

But let's wait confirmation from @amshakal

@americanrefugee
Copy link

Important: These should also be aligned with room alias permalinks.

@Velin92
Copy link
Member

Velin92 commented Feb 28, 2025

so far I have tested it on EW all the following cases:

  • if a permalink to an event using the room ID can't resolve the room it shows a pill with "Message in Room"
  • if a permalink to an event using room alias can't resolve the room it shows a pill with "Message in Room"
  • If a permalink to a room ID can't resolve the room it shows a pill with the raw room id displayed
  • If a permalink to a room alias can't resolve the room it shows a pill with the room alias displayed

Do we want to replicate the same behaviour of EW?
Or we should avoid leaking the raw room id and the room alias for these last two cases?

@mxandreas
Copy link

Do we want to replicate the same behaviour of EW?

I do not immediately see any significant and simple improvements to what EW does. Thus, propose to just replicate what it does for sake of consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants