Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no spinner after starting a DM from spotlight #23545

Closed
ara4n opened this issue Oct 19, 2022 · 5 comments
Closed

no spinner after starting a DM from spotlight #23545

ara4n opened this issue Oct 19, 2022 · 5 comments
Labels
A-DM-Start Creating a DM with another user A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce

Comments

@ara4n
Copy link
Member

ara4n commented Oct 19, 2022

Open spotlight search; search for a person via the user directory; hit enter to start a DM while on bad connectivity; see absolutely no feedback that the app is trying to start a DM. After a few minutes, suddenly get catapulted into the DM pre-compose screen
@florianduros florianduros added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-DM-Start Creating a DM with another user labels Oct 19, 2022
@weeman1337
Copy link
Contributor

As far as I can see spotlight does not have a loading state, yet
→ we need a design for this

@gaelledel
Copy link

Need to add the "Joining..." with loader - (already implemented no design required)

@dbkr
Copy link
Member

dbkr commented Mar 5, 2024

Should be a couple of hours to re-use the normal 'joining room' spinner (perhaps with a different title). Should be maintainer sized.

@t3chguy t3chguy self-assigned this Mar 19, 2024
@t3chguy
Copy link
Member

t3chguy commented Mar 21, 2024

image

Cannot reproduce the flow this is complaining about, @ara4n could you please share a recording of what you're encountering?

@t3chguy t3chguy removed their assignment Mar 21, 2024
@t3chguy
Copy link
Member

t3chguy commented Apr 24, 2024

Closing presumed no longer happening

@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DM-Start Creating a DM with another user A-DMs O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dbkr @ara4n @t3chguy @florianduros @weeman1337 @gaelledel @daniellekirkwood