Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Percy test: Configured room on IRC layout #26151

Closed
andybalaam opened this issue Sep 11, 2023 · 3 comments
Closed

Flaky Percy test: Configured room on IRC layout #26151

andybalaam opened this issue Sep 11, 2023 · 3 comments
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@andybalaam
Copy link
Member

andybalaam commented Sep 11, 2023 •
edited
Loading

Steps to reproduce

E.g. this Percy test: https://percy.io/dfde73bd/matrix-react-sdk/builds/30076401/changed/1664921294?browser=chrome&browser_ids=47%2C48%2C49&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=120%2C260%2C285%2C500%2C1024%2C1920 failed with a spinner appearing instead of the date divider:

Outcome

What did you expect?

image

What happened instead?

image
@andybalaam andybalaam added T-Defect Z-Flaky-Test A test is raising false alarms A-Developer-Experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 11, 2023
@kerryarchibald
Copy link
Contributor

https://percy.io/dfde73bd/matrix-react-sdk/builds/30602275/changed/1690802900?browser=firefox&browser_ids=47%2C48%2C49&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=original&width=1024&widths=264%2C580%2C796%2C1024%2C1920

@kerryarchibald kerryarchibald mentioned this issue Oct 17, 2023
Merged
3 tasks
@kerryarchibald
Copy link
Contributor

Attempted a fix here: matrix-org/matrix-react-sdk#11769
Should be disabled next time if that doesn't help as per https://handbook.element.io/books/web-app-team-wat/page/wat-flaky-test-policy

@richvdh
Copy link
Member

richvdh commented Jan 19, 2024

seems like kerry's fix worked!

@richvdh richvdh closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybalaam @richvdh @kerryarchibald