Visual appearance of dangerous buttons inconsistent

[kongo09]

Steps to reproduce

1. Go to Settings
2. Observe buttons with a delete action

Outcome

What did you expect?

Consisten appearance

What happened instead?

Buttons have different styles, outline and filled

Operating system

Windows 11

Application version

Element version: 1.11.60 Crypto version: Olm 3.2.15

How did you install the app?

No response

Homeserver

element.io

Will you send logs?

No

[bblacher]

Same as #27180

[kongo09]

Not sure if this is the same. There can be a case when a single button is highlighted to guide a user in a flow towards the next best action. A dangerous destructive RED button is typically never a next best action but a conscious special action.

[americanrefugee]

This is related to another issue (27180)

We will further consider the presentation of destructive actions when tackling Settings in general. But I agree with you, solid vs. outline destructive buttons in this case doesn't make sense.

[daniellekirkwood]

Added this to the list of issues as a part of the settings project

[daniellekirkwood]

@kongo09 I suggest that we close this issue as it will be handled with the Settings redesign.

If you disagree, feel free to reopen this task.

[kongo09]

Redesign still has two different button styles (2nd level and 3rd level) in different places.

[americanrefugee]

I've made the following changes, based on trying out different buttons styles to determine what looks best and minimizes scary features:

• Sign out buttons for the user's account and on the device detail page are secondary
  • When I tried tertiary styles / text links, it became too difficult to spot
  • Since some users will need to sign in and out every day, I felt that it was important to make this instance of a "destructive" button more prominent
• Sign out buttons for the device list (either OIDC or Legacy) are text links / tertiary
• Likewise, for all other destructive actions are also text links / tertiary

For reference, here's an example of a page with both styles.

Also, here is a device list and device details pages.

[kongo09]

Great point about the sign-out which indeed is a policy in some environments, which elevates it.

[daniellekirkwood]

Great, sounds like we've found the right compromise. The design files have been updated and the logic of where and why we use which button type agreed upon. Closing this task.