Visual appearance of action buttons inconsistent

[kongo09]

Steps to reproduce

1. Go to settings
2. Observe various action buttons

Outcome

What did you expect?

Consisten appearance

What happened instead?

Inconsistent appearance, some outlined, some filled

Operating system

Windows 11

Application version

Element version: 1.11.60 Crypto version: Olm 3.2.15

How did you install the app?

No response

Homeserver

element.io

Will you send logs?

No

[bblacher]

I think that's on purpose, the "more important" buttons are filled.

[kongo09]

I don't get it, what makes a button more important? There could be a guiding intent to help the user in a flow for the next best action but if that is the case is not very apparent

[bblacher]

It's literally being handled in the same way as it's always been, the only difference is the color and shape:

I can't seem to find where the screenshot you've got in the issue description comes from.

[kongo09]

The color is a step back and eliminates our brand further, but that's a different discussion as per: https://github.com/element-hq/element-internal/issues/536

In the example above I can relate to "Save" being the primary CTA and thus trying to keep the user in the flow of guiding along the next best action.

My screenshots from above are:

• Manage: Security & Privacy -> Message search (clearly not the next best action for that section)
• Submit debug logs: Help & About -> Bug reporting (actually the only action for that section)

[bblacher]

In those places I can't see a clear pattern why one button is filled and the other one is not, I agree.

[americanrefugee]

Jumping in here...

There seem to be 2 different, but related topics here:

1. ) The logic and appearance of primary vs. secondary actions
2. ) The perceived (im)balance of accessibility vs. the Element brand

What you see now is only a temporary in-between place. We haven't had the resources to do anything more than update some of the existing components with our new styles. But we've known for a long time that Settings needs to be rethought entirely with fresh eyes to address many issues besides the presentation of buttons.

Meanwhile, there was a time-limited effort last month to introduce more of the brand color into the components, including toggles and radio buttons. During that mini-sprint we explored other ways to infuse the interface with more of our brand. A lot of that thinking can easily be applied to Settings.

Fortunately, the next big project I'll be working on in the coming weeks will be Settings :) So, I'll be sure to take both of the above points into consideration when working on it.

@nadonomy feel free to add any more context in case I forgot something

[daniellekirkwood]

@kongo09 I suggest that we close this issue as it will be handled with the Settings redesign.

If you disagree, feel free to reopen this task.