Skip to content

Commit 5207d4b

Browse files
committed
Fix tests
1 parent bd8800c commit 5207d4b

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/accountprovider/AccountProviderDataSourceTest.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ class AccountProviderDataSourceTest {
2727
val initialState = awaitItem()
2828
assertThat(initialState).isEqualTo(
2929
AccountProvider(
30-
url = FakeEnterpriseService.A_FAKE_HOMESERVER,
31-
title = FakeEnterpriseService.A_FAKE_HOMESERVER,
30+
url = AuthenticationConfig.MATRIX_ORG_URL,
31+
title = "matrix.org",
3232
subtitle = null,
33-
isPublic = false,
34-
isMatrixOrg = false,
33+
isPublic = true,
34+
isMatrixOrg = true,
3535
isValid = false,
3636
)
3737
)
@@ -40,7 +40,8 @@ class AccountProviderDataSourceTest {
4040

4141
@Test
4242
fun `present - initial state - matrix org`() = runTest {
43-
val sut = AccountProviderDataSource(FakeEnterpriseService(
43+
val sut = AccountProviderDataSource(
44+
FakeEnterpriseService(
4445
defaultHomeserverListResult = { listOf(AuthenticationConfig.MATRIX_ORG_URL) }
4546
))
4647
sut.flow.test {
@@ -63,7 +64,7 @@ class AccountProviderDataSourceTest {
6364
val sut = AccountProviderDataSource(FakeEnterpriseService())
6465
sut.flow.test {
6566
val initialState = awaitItem()
66-
assertThat(initialState.url).isEqualTo(FakeEnterpriseService.A_FAKE_HOMESERVER)
67+
assertThat(initialState.url).isEqualTo(AuthenticationConfig.MATRIX_ORG_URL)
6768
sut.userSelection(AccountProvider(url = "https://example.com"))
6869
val changedState = awaitItem()
6970
assertThat(changedState).isEqualTo(
@@ -78,7 +79,7 @@ class AccountProviderDataSourceTest {
7879
)
7980
sut.reset()
8081
val resetState = awaitItem()
81-
assertThat(resetState.url).isEqualTo(FakeEnterpriseService.A_FAKE_HOMESERVER)
82+
assertThat(resetState.url).isEqualTo(AuthenticationConfig.MATRIX_ORG_URL)
8283
}
8384
}
8485
}

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenterTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import app.cash.molecule.RecompositionMode
1111
import app.cash.molecule.moleculeFlow
1212
import app.cash.turbine.test
1313
import com.google.common.truth.Truth.assertThat
14+
import io.element.android.appconfig.AuthenticationConfig
1415
import io.element.android.features.enterprise.test.FakeEnterpriseService
1516
import io.element.android.features.login.impl.DefaultLoginUserStory
1617
import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
@@ -44,7 +45,7 @@ class ConfirmAccountProviderPresenterTest {
4445
val initialState = awaitItem()
4546
assertThat(initialState.isAccountCreation).isFalse()
4647
assertThat(initialState.submitEnabled).isTrue()
47-
assertThat(initialState.accountProvider.url).isEqualTo(FakeEnterpriseService.A_FAKE_HOMESERVER)
48+
assertThat(initialState.accountProvider.url).isEqualTo(AuthenticationConfig.MATRIX_ORG_URL)
4849
assertThat(initialState.loginFlow).isEqualTo(AsyncData.Uninitialized)
4950
}
5051
}

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/createaccount/DefaultMessageParserTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package io.element.android.features.login.impl.screens.createaccount
99

1010
import com.google.common.truth.Truth.assertThat
11+
import io.element.android.appconfig.AuthenticationConfig
1112
import io.element.android.features.enterprise.test.FakeEnterpriseService
1213
import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
1314
import io.element.android.libraries.matrix.api.auth.external.ExternalSession
@@ -60,7 +61,7 @@ class DefaultMessageParserTest {
6061
// missing homeServer
6162
assertThat(sut.parse(validMessage.replace(""""home_server": "home_server",""", ""))).isEqualTo(
6263
anExternalSession(
63-
homeserverUrl = FakeEnterpriseService.A_FAKE_HOMESERVER,
64+
homeserverUrl = AuthenticationConfig.MATRIX_ORG_URL,
6465
)
6566
)
6667
}

features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/loginpassword/LoginPasswordPresenterTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package io.element.android.features.login.impl.screens.loginpassword
99

1010
import com.google.common.truth.Truth.assertThat
11+
import io.element.android.appconfig.AuthenticationConfig
1112
import io.element.android.features.enterprise.test.FakeEnterpriseService
1213
import io.element.android.features.login.impl.DefaultLoginUserStory
1314
import io.element.android.features.login.impl.accountprovider.AccountProviderDataSource
@@ -33,7 +34,7 @@ class LoginPasswordPresenterTest {
3334
fun `present - initial state`() = runTest {
3435
createLoginPasswordPresenter().test {
3536
val initialState = awaitItem()
36-
assertThat(initialState.accountProvider.url).isEqualTo(FakeEnterpriseService.A_FAKE_HOMESERVER)
37+
assertThat(initialState.accountProvider.url).isEqualTo(AuthenticationConfig.MATRIX_ORG_URL)
3738
assertThat(initialState.formState).isEqualTo(LoginFormState.Default)
3839
assertThat(initialState.loginAction).isEqualTo(AsyncData.Uninitialized)
3940
assertThat(initialState.submitEnabled).isFalse()

0 commit comments

Comments
 (0)