Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls don't use Themes (currently only light Theme) #3135

Closed
DoM1niC opened this issue Jul 3, 2024 · 2 comments
Closed

Calls don't use Themes (currently only light Theme) #3135

DoM1niC opened this issue Jul 3, 2024 · 2 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@DoM1niC
Copy link

DoM1niC commented Jul 3, 2024

Your use case

What would you like to do?

Theming from Element X native App Setting

Why would you like to do it?

We have light / dark Theme

How would you like to achieve it?

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@DoM1niC DoM1niC added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 3, 2024
@toger5
Copy link

toger5 commented Jul 4, 2024

This is supported by the rust widget driver and element call (Just tested it using the tauri widget wrapper)

widget_settings.generate_webview_url(&room, props)
// or kt
generateWebviewUrl(...)

Is where we can pass the theme as a string in props. So this could either be that android is passing null here or a more verbose string (only dark and light work currently (and i think their high contrast versions)).

Looking through the android code most of the things are hooked up so this probably needs someone debugging what is actually passed into generateWebviewUrl.

@bmarty
Copy link
Member

bmarty commented Jul 4, 2024

Done in #3118 , will be in the next release.

Duplicate of #3079

@bmarty bmarty closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants