Display name disambiguation #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied to: - timeline message - detail of timeline message - reply preview of timeline message - rendering of state Event Not applied to: - room last message - room member list (we display the MatrixId here) - room member detail page
|
To check: display name in reaction list: OK since we display Matrix Id here: |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
|
(waiting for final design) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2221 +/- ##
===========================================
+ Coverage 70.05% 70.06% +0.01%
===========================================
Files 1335 1335
Lines 32562 32568 +6
Branches 6757 6758 +1
===========================================
+ Hits 22810 22819 +9
+ Misses 6481 6479 -2
+ Partials 3271 3270 -1 ☔ View full report in Codecov by Sentry. |
|
Let's merge and iterate later on the design. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Display name disambiguation in the timeline.
Applied to:
Not applied to:
Motivation and context
Closes #2215
Screenshots / GIFs
From the room Element X Android:
Tests
In a room, give the same display name to 2 different users , and obersve that the Matrix Id is appended to it when they send message.
Tested devices
Checklist