Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in with QR code #2793

Merged
merged 67 commits into from
May 31, 2024

Fix maestro tests

7fad1a6
Select commit
Loading
Failed to load commit list.
Merged

Sign in with QR code #2793

Fix maestro tests
7fad1a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 31, 2024 in 0s

75.52% (+0.08%) compared to d89004f

View this Pull Request on Codecov

75.52% (+0.08%) compared to d89004f

Details

Codecov Report

Attention: Patch coverage is 78.96440% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (d89004f) to head (7fad1a6).
Report is 16 commits behind head on develop.

Files Patch % Lines
...ement/android/libraries/qrcode/QrCodeCameraView.kt 69.86% 15 Missing and 7 partials ⚠️
...s/login/impl/screens/qrcode/scan/QrCodeScanView.kt 83.69% 2 Missing and 13 partials ⚠️
...login/impl/screens/qrcode/error/QrCodeErrorView.kt 80.30% 0 Missing and 13 partials ⚠️
...eens/qrcode/confirmation/QrCodeConfirmationView.kt 84.84% 0 Missing and 10 partials ⚠️
...d/libraries/designsystem/utils/ForceOrientation.kt 0.00% 10 Missing ⚠️
...login/impl/screens/qrcode/intro/QrCodeIntroView.kt 73.52% 0 Missing and 9 partials ⚠️
...element/android/libraries/qrcode/QRCodeAnalyzer.kt 50.00% 7 Missing ⚠️
...in/impl/screens/qrcode/scan/QrCodeScanPresenter.kt 84.21% 1 Missing and 5 partials ⚠️
...ignsystem/utils/ForceOrientationInMobileDevices.kt 0.00% 5 Missing ⚠️
...ment/android/features/login/api/LoginEntryPoint.kt 0.00% 4 Missing ⚠️
... and 16 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2793      +/-   ##
===========================================
+ Coverage    75.43%   75.52%   +0.08%     
===========================================
  Files         1547     1576      +29     
  Lines        36845    37413     +568     
  Branches      7139     7262     +123     
===========================================
+ Hits         27793    28255     +462     
- Misses        5318     5358      +40     
- Partials      3734     3800      +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov