Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't intercept mas.element.io domain with our intent filters #2794

Closed
wants to merge 1 commit into from

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Instead of using *.element.io for intent filters, use the different element.io existing subdomains.

Motivation and context

Using *.element.io, the mas.element.io domain is intercepted too, preventing signing in using OIDC in the element.io homeserver.

Tests

  • If you can log into an element.io account, it works.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner May 3, 2024 19:40
@jmartinesp jmartinesp requested review from bmarty and removed request for a team May 3, 2024 19:40
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CTtFc4

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (e95d24d) to head (442cbda).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2794   +/-   ##
========================================
  Coverage    73.41%   73.41%           
========================================
  Files         1523     1523           
  Lines        36528    36528           
  Branches      7038     7038           
========================================
  Hits         26816    26816           
  Misses        6043     6043           
  Partials      3669     3669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<data android:host="app.element.io" />
<data android:host="staging.element.io" />
<data android:host="develop.element.io" />
<data android:host="call.element.io" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me double check that permalink still works on Android 12+. And if it's the case, maybe we can move back the call.element.io to the ElementCallActivity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeplink is broken with this, so I am afraid we will need to host the file assetlinks.json to several locations (which is probably better)

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
It breaks external permalink navigation, so I will fix the issue in another PR.

@bmarty bmarty closed this May 6, 2024
@bmarty bmarty mentioned this pull request May 6, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants