-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't intercept mas.element.io
domain with our intent filters
#2794
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2794 +/- ##
========================================
Coverage 73.41% 73.41%
========================================
Files 1523 1523
Lines 36528 36528
Branches 7038 7038
========================================
Hits 26816 26816
Misses 6043 6043
Partials 3669 3669 ☔ View full report in Codecov by Sentry. |
<data android:host="app.element.io" /> | ||
<data android:host="staging.element.io" /> | ||
<data android:host="develop.element.io" /> | ||
<data android:host="call.element.io" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let me double check that permalink still works on Android 12+. And if it's the case, maybe we can move back the call.element.io
to the ElementCallActivity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deeplink is broken with this, so I am afraid we will need to host the file assetlinks.json
to several locations (which is probably better)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
It breaks external permalink navigation, so I will fix the issue in another PR.
Type of change
Content
Instead of using
*.element.io
for intent filters, use the differentelement.io
existing subdomains.Motivation and context
Using
*.element.io
, themas.element.io
domain is intercepted too, preventing signing in using OIDC in theelement.io
homeserver.Tests
element.io
account, it works.Tested devices
Checklist