Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't intercept mas.element.io domain with our intent filters #2794

Closed
wants to merge 1 commit into from
Closed

Don't intercept mas.element.io domain with our intent filters #2794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@
<category android:name="android.intent.category.BROWSABLE" />

<data android:scheme="https" />
<data android:host="*.element.io" />
<!-- We can't use "*.element.io" here because it'll intercept the "mas.element.io" domain too. -->
<data android:host="app.element.io" />
<data android:host="staging.element.io" />
<data android:host="develop.element.io" />
<data android:host="call.element.io" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me double check that permalink still works on Android 12+. And if it's the case, maybe we can move back the call.element.io to the ElementCallActivity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeplink is broken with this, so I am afraid we will need to host the file assetlinks.json to several locations (which is probably better)

</intent-filter>
<!--
matrix.to links
Expand Down
Loading