Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Strings #3077

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Sync Strings #3077

merged 1 commit into from
Jun 24, 2024

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner June 24, 2024 00:23
@ElementBot ElementBot requested review from jmartinesp and removed request for a team June 24, 2024 00:23
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/neKPy7

Copy link

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (3d27f26) to head (61e8255).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3077      +/-   ##
===========================================
- Coverage    75.94%   75.93%   -0.01%     
===========================================
  Files         1632     1632              
  Lines        38524    38524              
  Branches      7442     7442              
===========================================
- Hits         29256    29255       -1     
  Misses        5390     5390              
- Partials      3878     3879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're missing German translations for this couple of strings.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@jmartinesp jmartinesp merged commit fd6bcb7 into develop Jun 24, 2024
28 checks passed
@jmartinesp jmartinesp deleted the sync-localazy branch June 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants