Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @room mentions crashing in debug builds #3107

Merged
merged 2 commits into from
Jun 27, 2024

Iterate on previous solution, add `MentionSpan.Type.EVERYONE`

bc967fe
Select commit
Loading
Failed to load commit list.
Merged

Fix @room mentions crashing in debug builds #3107

Iterate on previous solution, add `MentionSpan.Type.EVERYONE`
bc967fe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 27, 2024 in 0s

75.96% (-0.01%) compared to ed00ed4, passed because coverage increased by -0.01% when compared to adjusted base (75.97%)

View this Pull Request on Codecov

75.96% (-0.01%) compared to ed00ed4, passed because coverage increased by -0.01% when compared to adjusted base (75.97%)

Details

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (ed00ed4) to head (bc967fe).

Files Patch % Lines
...ries/textcomposer/model/MarkdownTextEditorState.kt 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3107      +/-   ##
===========================================
- Coverage    75.96%   75.96%   -0.01%     
===========================================
  Files         1636     1636              
  Lines        38618    38617       -1     
  Branches      7465     7463       -2     
===========================================
- Hits         29338    29335       -3     
- Misses        5392     5393       +1     
- Partials      3888     3889       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.