-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give locale and theme to Element Call #3118
Conversation
@@ -68,6 +70,7 @@ class CallScreenPresenter @AssistedInject constructor( | |||
private val screenTracker: ScreenTracker, | |||
private val appCoroutineScope: CoroutineScope, | |||
private val activeCallManager: ActiveCallManager, | |||
private val languageTagProvider: LanguageTagProvider, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduce a LanguageTagProvider because unit test does not like using LocalConfiguration
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3118 +/- ##
========================================
Coverage 75.95% 75.95%
========================================
Files 1636 1637 +1
Lines 38613 38622 +9
Branches 7463 7465 +2
========================================
+ Hits 29328 29335 +7
- Misses 5396 5397 +1
- Partials 3889 3890 +1 ☔ View full report in Codecov by Sentry. |
Type of change
Content
Use Element Call with correct theme and language.
Motivation and context
Improve user experience and closes #3079
Screenshots / GIFs
Tests
Tested devices
Checklist