-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft : add volatile storage when moving to edit mode. #3132
Changes from 2 commits
afd13ab
82838d6
8306625
008ba4f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
* Copyright (c) 2024 New Vector Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.element.android.features.messages.impl.draft | ||
|
||
import io.element.android.libraries.matrix.api.core.RoomId | ||
import io.element.android.libraries.matrix.api.room.draft.ComposerDraft | ||
|
||
interface ComposerDraftStore { | ||
suspend fun loadDraft(roomId: RoomId): ComposerDraft? | ||
suspend fun updateDraft(roomId: RoomId, draft: ComposerDraft?) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright (c) 2024 New Vector Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.element.android.features.messages.impl.draft | ||
|
||
import io.element.android.libraries.matrix.api.MatrixClient | ||
import io.element.android.libraries.matrix.api.core.RoomId | ||
import io.element.android.libraries.matrix.api.room.draft.ComposerDraft | ||
import timber.log.Timber | ||
import javax.inject.Inject | ||
|
||
class MatrixComposerDraftStore @Inject constructor( | ||
private val client: MatrixClient, | ||
Check warning on line 26 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
) : ComposerDraftStore { | ||
override suspend fun loadDraft(roomId: RoomId): ComposerDraft? { | ||
return client.getRoom(roomId)?.use { room -> | ||
room.loadComposerDraft() | ||
Check warning on line 30 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
.onFailure { | ||
Timber.e(it, "Failed to load composer draft for room $roomId") | ||
Check warning on line 32 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} | ||
.onSuccess { draft -> | ||
room.clearComposerDraft() | ||
Timber.d("Loaded composer draft for room $roomId : $draft") | ||
Check warning on line 36 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} | ||
.getOrNull() | ||
} | ||
} | ||
|
||
override suspend fun updateDraft(roomId: RoomId, draft: ComposerDraft?) { | ||
client.getRoom(roomId)?.use { room -> | ||
val updateDraftResult = if (draft == null) { | ||
room.clearComposerDraft() | ||
Check warning on line 45 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} else { | ||
room.saveComposerDraft(draft) | ||
Check warning on line 47 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} | ||
updateDraftResult | ||
Check warning on line 49 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
.onFailure { | ||
Timber.e(it, "Failed to update composer draft for room $roomId") | ||
Check warning on line 51 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} | ||
.onSuccess { | ||
Timber.d("Updated composer draft for room $roomId") | ||
Check warning on line 54 in features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/draft/MatrixComposerDraftStore.kt
|
||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Copyright (c) 2024 New Vector Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.element.android.features.messages.impl.draft | ||
|
||
import io.element.android.libraries.matrix.api.core.RoomId | ||
import io.element.android.libraries.matrix.api.room.draft.ComposerDraft | ||
import javax.inject.Inject | ||
|
||
class VolatileComposerDraftStore @Inject constructor() : ComposerDraftStore { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add docs on the 2 draft stores? |
||
private val drafts: MutableMap<RoomId, ComposerDraft> = mutableMapOf() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's weird to store the draft in a map since a new |
||
|
||
override suspend fun loadDraft(roomId: RoomId): ComposerDraft? { | ||
// Remove the draft from the map when it is loaded | ||
return drafts.remove(roomId) | ||
} | ||
|
||
override suspend fun updateDraft(roomId: RoomId, draft: ComposerDraft?) { | ||
if (draft == null) { | ||
drafts.remove(roomId) | ||
} else { | ||
drafts[roomId] = draft | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe introduce a
getStore
fun to be able to write: