Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all callback plugins are invoked. #3146

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 5, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Technically, there should be only one callback, but for codebase consistency, ensure that we invoke all the instance.
Adding a Konsist test to check that.

Motivation and context

Codebase consistency

Screenshots / GIFs

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Jul 5, 2024
@bmarty bmarty requested a review from a team as a code owner July 5, 2024 10:17
@bmarty bmarty requested review from ganfra and removed request for a team July 5, 2024 10:17
Copy link

sonarqubecloud bot commented Jul 5, 2024

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (c3ca3d9) to head (a7de751).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3146   +/-   ##
========================================
  Coverage    76.02%   76.02%           
========================================
  Files         1635     1635           
  Lines        38609    38609           
  Branches      7467     7467           
========================================
  Hits         29353    29353           
  Misses        5366     5366           
  Partials      3890     3890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jGvT2J

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
@bmarty bmarty merged commit 97f3959 into develop Jul 9, 2024
34 checks passed
@bmarty bmarty deleted the feature/bma/invokeAllCallbacks branch July 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants