Always follow the desired theme for Pin, Incoming Call and Element Call screens

[bmarty]

Content

Fix several issue around theming: Pin and Incoming call was not using the application setting for theme.
ElementCall was reading the current theme but before it was set.

Motivation and context

Dark theme everywhere when selected manually by the user or by following the system setting.

Closes #3153

Screenshots / GIFs

Tests

• Set dark theme
• Start a call
• Observe that we now have a dark Element Call rendering.
• Set up PIN code
• Put the app to bg then to fg
• Now: dark screen to enter pin code. Previously: light version
• Same for incoming call screen.

I was confused by the icon change in the screenshot at #3118 , but now the icons are always the same, which is also a bit confusing. But this is on the web part.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2FX9LN

[codecov]

Codecov Report

Attention: Patch coverage is 71.64179% with 19 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (b0c9091) to head (bb5ae89).

Files	Patch %	Lines
...id/libraries/designsystem/theme/ElementThemeApp.kt	0.00%	7 Missing ⚠️
...roid/features/call/impl/ui/IncomingCallActivity.kt	0.00%	6 Missing ⚠️
...droid/features/call/impl/ui/ElementCallActivity.kt	0.00%	2 Missing ⚠️
...ckscreen/impl/unlock/activity/PinUnlockActivity.kt	0.00%	2 Missing ⚠️
...c/main/kotlin/io/element/android/x/MainActivity.kt	0.00%	1 Missing ⚠️
...ndroid/features/call/impl/ui/IncomingCallScreen.kt	97.95%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3165   +/-   ##
========================================
  Coverage    76.11%   76.11%           
========================================
  Files         1640     1641    +1     
  Lines        38622    38622           
  Branches      7469     7471    +2     
========================================
+ Hits         29396    29397    +1     
  Misses        5333     5333           
+ Partials      3893     3892    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Thanks, LGTM!

[bmarty]

@jmartinesp I have added another commit, can you double check please?

Also I have found an issue about assets stored in -nightly resource folder, this may be handled in a separate issue: #3168

[jmartinesp]

Having the design system library depending on the preferences one is a bit weird to be honest. Maybe this should be in a separate module that depends on both? Although that also sounds like an overkill.

[bmarty]

Yes, it's not a big deal to me, and it's better than duplicated code. Also in the future (EXE) it's better to centralize where the application theme is configured.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud