-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe to RoomListItems
in the visible range
#3169
Subscribe to RoomListItems
in the visible range
#3169
Conversation
This ensures the room list items always have updated info.
08a5772
to
c7d7c45
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
f5a9919
to
1d1c356
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3169 +/- ##
===========================================
+ Coverage 76.11% 76.12% +0.01%
===========================================
Files 1641 1641
Lines 38624 38646 +22
Branches 7471 7476 +5
===========================================
+ Hits 29397 29420 +23
Misses 5335 5335
+ Partials 3892 3891 -1 ☔ View full report in Codecov by Sentry. |
…e-items-with-no-latest-event
|
This ensures the room list items always have updated info.
Content
RoomListItems
in the visible range so we always have updated info for them. This also helps preload the data rendered when you open one of those rooms.Motivation and context
Fixes a limitation introduced by the client side sorting since we no longer use SlidingSync's
visible_rooms
and only fetch the latest event of all the room list items (which, if it's a state event, won't be displayed in the room list).Tests
Tested devices
Checklist