-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Maestro run for each PR push #4121
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
9cc8075
to
18489b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4121 +/- ##
========================================
Coverage 83.28% 83.28%
========================================
Files 1885 1885
Lines 49096 49096
Branches 5764 5764
========================================
Hits 40888 40888
Misses 6139 6139
Partials 2069 2069 ☔ View full report in Codecov by Sentry. |
65a349c
to
7ac00ec
Compare
0f45363
to
a99a0e3
Compare
36bd26b
to
46dcca1
Compare
- Remove the `workflow_run` configuration for the Maestro job. - Make the 'build apk' job always run again too. - Make sure the test results are uploaded when the Maestro job fails too (this broke somehow).
46dcca1
to
42a276b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up!
Content
Follow up of #4092, since it wasn't working as expected.
workflow_run
configuration for the Maestro job.Motivation and context
Ideally we wanted to run Maestro once the 'Build APK' flow was finished and reuse its output so we don't have to build the APK twice, but this has proven difficult to achieve, since the 2 options GH actions gives us for that are:
workflow_run
, which can set up dependencies in a 'when X flow finishes, run flow Y' way, and it's technically what we want, but has the downside that it'll always use the.yml
contents of thedevelop
branch, which makes it difficult to maintain or change (as proven by Test using Maestro CLI + emulator instead of Cloud #4092 not really working after being merged).workflow_call
, which allows a flow to explicitly start another: it worked as seen in this commit, but ended up in either theMaestro
flow being run and displayed as part of theBuild APK
one or viceversa, and in both cases it was quite awkward since you couldn't see the results directly in the 'checks' UI.So in the end we're just re-building the APK until a better option appears.
Tests
There should be a working 'Maestro (local)' flow in the list of actions run.
Checklist