Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust sdk 0.2.75 #4158

Merged
merged 6 commits into from
Jan 17, 2025
Merged

update rust sdk 0.2.75 #4158

merged 6 commits into from
Jan 17, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jan 16, 2025

Content

This PR updates the rust sdk to 0.2.75.
It does include breaking change on tracing because of matrix-org/matrix-rust-sdk#4492.

I've simplified the screens so we just include the LogLevel in developper settings.
For this I've introduced a new PreferenceDropdown component.

Can be reviewed commit by commit.

Motivation and context

New sdk https://github.com/matrix-org/matrix-rust-components-kotlin/releases/tag/sdk-v0.2.75

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added PR-Change For updates to an existing feature PR-Dependencies Pull requests that update a dependency file Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Jan 16, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5yERbS

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 16, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 16, 2025
@ganfra ganfra marked this pull request as ready for review January 16, 2025 18:15
@ganfra ganfra requested a review from a team as a code owner January 16, 2025 18:15
@ganfra ganfra requested review from bmarty and removed request for a team January 16, 2025 18:15
@ganfra ganfra force-pushed the feature/fga/update_rust_sdk_0.2.75 branch from ad40de1 to 7d27e65 Compare January 17, 2025 08:56
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 17, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 77.70270% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.31%. Comparing base (0d63610) to head (599972a).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...lement/android/x/initializer/TracingInitializer.kt 0.00% 9 Missing ⚠️
...eferences/impl/developer/tracing/LogLevelMapper.kt 25.00% 7 Missing and 2 partials ⚠️
...eferences/impl/store/DefaultAppPreferencesStore.kt 0.00% 8 Missing ⚠️
...ures/rageshake/impl/reporter/DefaultBugReporter.kt 0.00% 2 Missing and 1 partial ⚠️
...ystem/components/preferences/PreferenceDropdown.kt 97.18% 0 Missing and 2 partials ⚠️
...braries/matrix/api/tracing/TracingConfiguration.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4158      +/-   ##
===========================================
+ Coverage    83.28%   83.31%   +0.03%     
===========================================
  Files         1886     1881       -5     
  Lines        49185    49101      -84     
  Branches      5777     5769       -8     
===========================================
- Hits         40962    40909      -53     
+ Misses        6145     6116      -29     
+ Partials      2078     2076       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -156,7 +156,7 @@ class DefaultBugReporter @Inject constructor(
if (crashCallStack.isNotEmpty() && withCrashLogs) {
builder.addFormDataPart("label", "crash")
}
currentTracingFilter?.let {
currentTracingLogLevel?.let {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change on next line tracing_filter to tracing_log_level

@ganfra ganfra enabled auto-merge January 17, 2025 15:59
@ganfra ganfra merged commit d5c2b7f into develop Jan 17, 2025
26 checks passed
@ganfra ganfra deleted the feature/fga/update_rust_sdk_0.2.75 branch January 17, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants