Code

Create SyncOrchestrator#4176

Code

Merged

jmartinesp merged 15 commits intodevelopelement-hq/element-x-android:developfrom refactor/sync-observerelement-hq/element-x-android:refactor/sync-observerCopy head branch name to clipboardFeb 6, 2025

+851-344

Commits

Commits on Feb 5, 2025

• Create SyncOrchestrator to centralise the sync start/stop flow through the whole app.

  Show description for 85f7e5e
  jmartinesp

  committed
  85f7e5e

  Copy full SHA for 85f7e5e

• Fix errors after rebase

  jmartinesp

  committed
  64f5a30

  Copy full SHA for 64f5a30

• Make network monitor return network connectivity status, not internet connectivity

  jmartinesp

  committed
  fa41a0a

  Copy full SHA for fa41a0a

• Don't stop the SyncService when network connection is lost, let it fail instead

  Show description for 4218140
  jmartinesp

  committed
  4218140

  Copy full SHA for 4218140

• Rename NetworkStatus.Online/Offline to Connected/Disconnected so they're not easily mistaken with internet connectivity instead

  jmartinesp

  committed
  64abdf6

  Copy full SHA for 64abdf6

• Remove DefaultSyncOrchestrator.stop()

  jmartinesp

  committed
  68aa4a4

  Copy full SHA for 68aa4a4

• Start the SyncOrchestrator as soon as the Client is created

  jmartinesp

  committed
  d1f2240

  Copy full SHA for d1f2240

• Remove the force initial sync, the orchestrator should handle that in the existing loop when offline mode is enabled for the Client in the SDK

  jmartinesp

  committed
  d1afcb4

  Copy full SHA for d1afcb4

• Remove SyncOrchestrator interface, rename DefaultSyncOrchestrator to it, remove the existing provider interface.

  jmartinesp

  committed
  27e841a

  Copy full SHA for 27e841a

• Use the right coroutine scope for SyncOrchestrator: before the app coroutine scope was being incorrectly injected instead.

  jmartinesp

  committed
  b38464c

  Copy full SHA for b38464c

• Add test to ensure the delay for stopping the sync is honoured

  jmartinesp

  committed
  ef8c524

  Copy full SHA for ef8c524

Commits on Feb 6, 2025

• Restore logout code

  jmartinesp

  committed
  efcc10c

  Copy full SHA for efcc10c

• Nit fixes

  jmartinesp

  committed
  07ed484

  Copy full SHA for 07ed484

• Replace the delay with a debounce for stopping the sync, simplify tests

  jmartinesp

  committed
  ecd76d8

  Copy full SHA for ecd76d8

• Fix lint issues caused by whitespace

  jmartinesp

  committed
  b3bba14

  Copy full SHA for b3bba14