Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matrix Room API and allow media swipe on pinned event only. #4274

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 17, 2025

Content

When a media is opened from the pinned events list, swiping left and right allow navigation between pinned events only

Motivation and context

Part of media browser https://github.com/element-hq/element-internal/issues/653

Screenshots / GIFs

MediaViewer_PinnedEvent.mp4

Tests

  • pinned some images
  • open the pinned events list
  • click on an image
  • swipe left/right and observe that only pinned events are visible

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 17, 2025 15:48
@bmarty bmarty requested review from jmartinesp and removed request for a team February 17, 2025 15:48
Copy link
Contributor

github-actions bot commented Feb 17, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/LFebak

@bmarty bmarty added the PR-Feature For a new feature label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 29.87013% with 54 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (728a2c1) to head (f36e341).
Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% 51 Missing ⚠️
...libraries/mediaviewer/api/MediaViewerEntryPoint.kt 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4274      +/-   ##
===========================================
- Coverage    80.06%   80.05%   -0.01%     
===========================================
  Files         2051     2052       +1     
  Lines        54574    54583       +9     
  Branches      6666     6680      +14     
===========================================
+ Hits         43695    43699       +4     
- Misses        8594     8599       +5     
  Partials      2285     2285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member Author

bmarty commented Feb 18, 2025

@jmartinesp i have updated the PR with cc11677 to improve the API, let me know if you have other remarks. Thanks!

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a possible issue with a duplicate line, please check it. Other than that and maybe some code tidy up I think it's good.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 86afffb into develop Feb 19, 2025
26 of 28 checks passed
@bmarty bmarty deleted the feature/bma/mediaTimelineImprovment branch February 19, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants