-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Matrix Room API and allow media swipe on pinned event only. #4274
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4274 +/- ##
===========================================
- Coverage 80.06% 80.05% -0.01%
===========================================
Files 2051 2052 +1
Lines 54574 54583 +9
Branches 6666 6680 +14
===========================================
+ Hits 43695 43699 +4
- Misses 8594 8599 +5
Partials 2285 2285 ☔ View full report in Codecov by Sentry. |
@jmartinesp i have updated the PR with cc11677 to improve the API, let me know if you have other remarks. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a possible issue with a duplicate line, please check it. Other than that and maybe some code tidy up I think it's good.
.../matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustMatrixRoom.kt
Outdated
Show resolved
Hide resolved
.../matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustMatrixRoom.kt
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Content
When a media is opened from the pinned events list, swiping left and right allow navigation between pinned events only
Motivation and context
Part of media browser https://github.com/element-hq/element-internal/issues/653
Screenshots / GIFs
MediaViewer_PinnedEvent.mp4
Tests
Tested devices
Checklist