Feature : join room by address #4302

ganfra · 2025-02-25T15:09:12Z

Content

This PR allows to join a room by his address (aka alias).
It's a new entry in the start chat actions, and is displayed inside a bottom sheet.
It includes the following changes :

Home FAB icon has been changed ( to be +)
TextField has now a validity state, defaulting to None
The feature itself

Motivation and context

Closes #4278

Screenshots / GIFs

See recorded screenshots.

Tests

Click on the home fab
Click on "Join room by address"
Play with address field (invalid address, valid address etc)

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

…bool)

github-actions · 2025-02-25T15:21:15Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Di7ERG

bmarty · 2025-02-25T15:27:49Z

...stem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/TextField.kt

 @Composable
 internal fun TextFieldsDarkPreview() = ElementPreviewDark { ContentToPreview() }

 @Composable
 @ExcludeFromCoverage
 private fun ContentToPreview() {
    Column(modifier = Modifier.padding(4.dp)) {
-        allBooleans.forEach { isError ->
+        TextFieldValidity.entries.forEach { validity ->


Could be nice to have the preview to the null validity, since it's a possible value.
Or add TextFieldValidity.None in the enum and make the parameter non-nullable and default to it?

Yes I was a bit hesitant about the TextFieldValidity.None, but if you think it's ok I'll add it!

I think it will be a bit cleaner, but I let you decide.

bmarty

LGTM, thanks!

bmarty · 2025-02-25T15:33:25Z

...tlin/io/element/android/features/createroom/impl/joinbyaddress/JoinRoomByAddressPresenter.kt

+                            RoomAddressState.RoomNotFound
+                        }
+                    },
+                    onFailure = { _ -> RoomAddressState.RoomNotFound }


We should maybe handle network error case separately?

For now I'll leave it like this, will see with design/product, but I think it's ok

bmarty · 2025-02-25T15:37:02Z

...ures/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListView.kt

@@ -153,7 +153,7 @@ private fun RoomListScaffold(
                ) {
                    Icon(
                        // Note cannot use Icons.Outlined.EditSquare, it does not exist :/
-                        imageVector = CompoundIcons.Compose(),
+                        imageVector = CompoundIcons.Plus(),


Maybe remove the outdated comment above?

bmarty · 2025-02-25T15:37:18Z

...in/io/element/android/features/securebackup/impl/reset/password/ResetIdentityPasswordView.kt

-            .fillMaxWidth()
-            .onTabOrEnterKeyFocusNext(LocalFocusManager.current),
+                .fillMaxWidth()
+                .onTabOrEnterKeyFocusNext(LocalFocusManager.current),


Revert formatting?

codecov · 2025-02-25T15:48:52Z

Codecov Report

Attention: Patch coverage is 88.08290% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (1a7a8a8) to head (f00337e).
Report is 15 commits behind head on develop.

Files with missing lines	Patch %	Lines
...android/features/createroom/CreateRoomNavigator.kt	0.00%	8 Missing ⚠️
...m/impl/joinbyaddress/JoinRoomByAddressPresenter.kt	85.96%	4 Missing and 4 partials ⚠️
...braries/designsystem/theme/components/TextField.kt	85.71%	2 Missing and 2 partials ⚠️
...teroom/impl/joinbyaddress/JoinRoomByAddressView.kt	95.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4302      +/-   ##
===========================================
+ Coverage    80.12%   80.15%   +0.03%     
===========================================
  Files         2053     2059       +6     
  Lines        54615    54790     +175     
  Branches      6686     6708      +22     
===========================================
+ Hits         43761    43918     +157     
- Misses        8565     8575      +10     
- Partials      2289     2297       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2025-02-25T19:49:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ganfra added 11 commits February 25, 2025 15:45

feat(join by alias) : replace Icons.Compose by Icons.Plus on home

21c6f92

feat(join by alias) : refactor navigation for create room flow

2bfa629

feat(join by alias) : introduce the JoinRoomByAddress

498f63e

design(text field) : allow setting validity (instead of just isError …

786c2ad

…bool)

feat(join by alias) : better address keyboard config

41fe0f1

feat(join by alias) : improve state management

676032d

feat(join by alias) : use correct room icon

b42825c

feat(join by alias) : use localazy strings

818af20

feat(join by alias) : makes sure to pass server names

c220fb0

feat(join by alias) : add tests

14082bc

feat(join by alias) : format code

6f8ca62

ganfra added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Feature For a new feature labels Feb 25, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 25, 2025

ganfra marked this pull request as ready for review February 25, 2025 15:21

ganfra requested a review from a team as a code owner February 25, 2025 15:21

ganfra requested review from bmarty and removed request for a team February 25, 2025 15:21

bmarty reviewed Feb 25, 2025

View reviewed changes

bmarty approved these changes Feb 25, 2025

View reviewed changes

ganfra added 2 commits February 25, 2025 20:27

feat(join by alias) : add TextFieldValidity.None instead of nullable

25d39c2

feat(join by alias) : small clean up

a6c3428

ganfra force-pushed the feature/fga/join_room_by_alias branch from 683e249 to a6c3428 Compare February 25, 2025 19:28

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 25, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 25, 2025

Update screenshots

f00337e

ganfra merged commit efb5acc into develop Feb 26, 2025
28 checks passed

ganfra deleted the feature/fga/join_room_by_alias branch February 26, 2025 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature : join room by address #4302

Feature : join room by address #4302

ganfra commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

bmarty Feb 25, 2025

ganfra Feb 25, 2025

bmarty Feb 25, 2025

bmarty left a comment

bmarty Feb 25, 2025

ganfra Feb 25, 2025

bmarty Feb 25, 2025

bmarty Feb 25, 2025

codecov bot commented Feb 25, 2025 •

edited

Loading

sonarqubecloud bot commented Feb 25, 2025

Feature : join room by address #4302

Feature : join room by address #4302

Conversation

ganfra commented Feb 25, 2025 • edited Loading

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions bot commented Feb 25, 2025 • edited Loading

bmarty Feb 25, 2025

Choose a reason for hiding this comment

ganfra Feb 25, 2025

Choose a reason for hiding this comment

bmarty Feb 25, 2025

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty Feb 25, 2025

Choose a reason for hiding this comment

ganfra Feb 25, 2025

Choose a reason for hiding this comment

bmarty Feb 25, 2025

Choose a reason for hiding this comment

bmarty Feb 25, 2025

Choose a reason for hiding this comment

codecov bot commented Feb 25, 2025 • edited Loading

Codecov Report

sonarqubecloud bot commented Feb 25, 2025

Quality Gate passed

ganfra commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Feb 25, 2025 •

edited

Loading

codecov bot commented Feb 25, 2025 •

edited

Loading