Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Material icons with Compound icons wherever it's possible #4323

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 26, 2025

Content

Migrate to CompoundIcon when the icon exist.

Motivation and context

Less usage of Material icons

Screenshots / GIFs

Check recorded ones

Tests

  • Check recorded screenshot, the diff should be minimal.

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 26, 2025 21:21
@bmarty bmarty requested review from ganfra and removed request for a team February 26, 2025 21:21
@bmarty bmarty added the PR-Misc For other changes label Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Z2tiWE

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 26, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (91cf716) to head (78c90b7).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
...aries/mediaviewer/impl/local/file/MediaFileView.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4323      +/-   ##
===========================================
- Coverage    80.17%   80.17%   -0.01%     
===========================================
  Files         2058     2058              
  Lines        54792    54793       +1     
  Branches      6707     6708       +1     
===========================================
  Hits         43928    43928              
  Misses        8565     8565              
- Partials      2299     2300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit af08d91 into develop Feb 27, 2025
28 checks passed
@bmarty bmarty deleted the feature/bma/compoundIcons branch February 27, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants