Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get library ComposablePreviewScanner from maven and update to the latest version #4327

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 27, 2025

Content

Get library ComposablePreviewScanner from Maven instead of Jitpack and update it to the latest version 0.5.1.

I tried to use the new api (available since 0.1.3, so not that new) includePrivatePreviews and make our preview methods private. This is working, but Showkase still need the preview to be internal.

Maybe we could get ride of Showkase at some point, not sure it's used lot.

It's worth noting that the library claims that the latest releases are improving the performance 🚀

Motivation and context

Fix Renovate complaining about not be able to update the library (see #150)

image

With this change, Renovate will now be able to upgrade it when necessary.

Screenshots / GIFs

No impact hopefully.

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…est version.

Renovate will now be able to upgrade it when necessary.
@bmarty bmarty requested a review from a team as a code owner February 27, 2025 08:35
@bmarty bmarty requested review from ganfra and removed request for a team February 27, 2025 08:35
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 27, 2025
@bmarty
Copy link
Member Author

bmarty commented Feb 27, 2025

Triggered a recording of the screenshot to ensure that there is no problem.

@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 27, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NkAKV4

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (21cd45b) to head (d2e51f1).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4327   +/-   ##
========================================
  Coverage    80.17%   80.17%           
========================================
  Files         2058     2058           
  Lines        54792    54792           
  Branches      6707     6707           
========================================
  Hits         43928    43928           
  Misses        8565     8565           
  Partials      2299     2299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added PR-Build For changes related to build, tools, CI/CD PR-Dependencies Pull requests that update a dependency file labels Feb 27, 2025
@bmarty bmarty merged commit 03ed740 into develop Feb 27, 2025
31 of 32 checks passed
@bmarty bmarty deleted the feature/bma/mavenAndroidComposablePreviewScanner branch February 27, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants