Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(create room) : use history visibility "invited" #4335

Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Feb 27, 2025

Content

Override the room history visibility with RoomHistoryVisibility.Invited when creating a private room.

Motivation and context

Closes #4331

Screenshots / GIFs

No ui changes.

Tests

  • Click on the "Start room" fab
  • Click on new room
  • Configure the room as a private one
  • Check the history visibility is correctly set to "invited"

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Change For updates to an existing feature label Feb 27, 2025
@ganfra ganfra marked this pull request as ready for review February 27, 2025 16:28
@ganfra ganfra requested a review from a team as a code owner February 27, 2025 16:28
@ganfra ganfra requested review from bmarty and removed request for a team February 27, 2025 16:28
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/w4u1cX

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (7aa6a43) to head (8e68490).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/libraries/matrix/impl/RustMatrixClient.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4335   +/-   ##
========================================
  Coverage    80.18%   80.18%           
========================================
  Files         2058     2058           
  Lines        54799    54802    +3     
  Branches      6705     6706    +1     
========================================
+ Hits         43942    43945    +3     
- Misses        8560     8561    +1     
+ Partials      2297     2296    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@@ -175,6 +176,7 @@ class ConfigureRoomPresenter @Inject constructor(
isEncrypted = config.roomVisibility is RoomVisibilityState.Private,
isDirect = false,
visibility = RoomVisibility.Private,
historyVisibilityOverride = RoomHistoryVisibility.Invited,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to check that in a unit test, but it's more work. givenCreateRoomResult is not enough, we should use a lambdaRecorder. Can be done later maybe.

@ganfra ganfra merged commit ec8c2e9 into develop Mar 3, 2025
29 of 30 checks passed
@ganfra ganfra deleted the feature/fga/create_room_override_history_visibility branch March 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Set history visibility to "invited" when creating private room
2 participants