-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(create room) : use history visibility "invited" #4335
change(create room) : use history visibility "invited" #4335
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4335 +/- ##
========================================
Coverage 80.18% 80.18%
========================================
Files 2058 2058
Lines 54799 54802 +3
Branches 6705 6706 +1
========================================
+ Hits 43942 43945 +3
- Misses 8560 8561 +1
+ Partials 2297 2296 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks!
@@ -175,6 +176,7 @@ class ConfigureRoomPresenter @Inject constructor( | |||
isEncrypted = config.roomVisibility is RoomVisibilityState.Private, | |||
isDirect = false, | |||
visibility = RoomVisibility.Private, | |||
historyVisibilityOverride = RoomHistoryVisibility.Invited, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to check that in a unit test, but it's more work. givenCreateRoomResult
is not enough, we should use a lambdaRecorder. Can be done later maybe.
Content
Override the room history visibility with
RoomHistoryVisibility.Invited
when creating a private room.Motivation and context
Closes #4331
Screenshots / GIFs
No ui changes.
Tests
Tested devices
Checklist