Skip to content

Let EnterpriseService provides push gateways #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 12, 2025

Content

Let EnterpriseService provides push gateways

Motivation and context

See internal issue.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Mar 12, 2025
@bmarty bmarty requested a review from a team as a code owner March 12, 2025 16:23
@bmarty bmarty requested review from jmartinesp and removed request for a team March 12, 2025 16:23
@bmarty
Copy link
Member Author

bmarty commented Mar 12, 2025

I expect the enterprise build to fail. If the API is OK, I can push a fix for it.

Copy link
Contributor

github-actions bot commented Mar 12, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jgfUBR

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, thanks!

@bmarty bmarty enabled auto-merge March 13, 2025 10:39
Copy link

@bmarty bmarty merged commit 07925cc into develop Mar 13, 2025
29 checks passed
@bmarty bmarty deleted the feature/bma/customPushGateway branch March 13, 2025 11:01
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (54ab4d2) to head (5d881e8).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
.../pushproviders/firebase/FirebaseGatewayProvider.kt 0.00% 3 Missing ⚠️
...s/unifiedpush/DefaultPushGatewayHttpUrlProvider.kt 0.00% 3 Missing ⚠️
...atures/enterprise/impl/DefaultEnterpriseService.kt 0.00% 2 Missing ⚠️
.../features/enterprise/test/FakeEnterpriseService.kt 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4400      +/-   ##
===========================================
- Coverage    80.10%   80.09%   -0.02%     
===========================================
  Files         2063     2065       +2     
  Lines        55180    55195      +15     
  Branches      6765     6767       +2     
===========================================
+ Hits         44201    44206       +5     
- Misses        8664     8674      +10     
  Partials      2315     2315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants