Skip to content

Disable click effect on Stickers #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 12, 2025

Content

Disable click effect on Stickers

Motivation and context

Closes #4342

Screenshots / GIFs

Tests

  • Send a sticker to a room
  • Try to click on the sticker
  • The media viewer does not open.
  • Long click is still possible

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Mar 12, 2025
@bmarty bmarty requested a review from a team as a code owner March 12, 2025 17:25
@bmarty bmarty requested review from ganfra and removed request for a team March 12, 2025 17:25
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PBb6um

Copy link

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (3ca6246) to head (17f6624).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4401   +/-   ##
========================================
  Coverage    80.10%   80.10%           
========================================
  Files         2063     2063           
  Lines        55180    55180           
  Branches      6765     6765           
========================================
  Hits         44201    44201           
  Misses        8664     8664           
  Partials      2315     2315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 54ab4d2 into develop Mar 12, 2025
36 checks passed
@bmarty bmarty deleted the feature/bma/disableClickOnSticker branch March 12, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new media viewer does not display stickers
2 participants