-
Notifications
You must be signed in to change notification settings - Fork 230
Add feature flag to let the application prints logs to logcat in release builds. #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17b9702
to
0111816
Compare
0111816
to
b73c447
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4402 +/- ##
===========================================
- Coverage 80.10% 80.10% -0.01%
===========================================
Files 2063 2063
Lines 55180 55187 +7
Branches 6765 6766 +1
===========================================
+ Hits 44201 44206 +5
- Misses 8664 8665 +1
- Partials 2315 2316 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I do not agree with this change, and I have commented the issue here #4011 (comment) |
… or not This is done so it can be temporarily enabled on release builds for quick debugging sessions, then disabled again.
The new changes should be more aligned with what we agreed on, I've updated the description of the PR too. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Content
Logs in logcat are enabled now by default in debug and nightly builds based on a new feature flag that can be toggled in the developer options screen, so they can be temporarily enabled in release builds if necessary, while they're disabled by default on those.
Motivation and context
Fixes #4011.
Screenshots
Tested devices
Checklist