-
Notifications
You must be signed in to change notification settings - Fork 226
Update SDK version to 25.03.13
and fix breaking changes
#4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4406 +/- ##
===========================================
- Coverage 80.04% 80.02% -0.03%
===========================================
Files 2071 2072 +1
Lines 55335 55349 +14
Branches 6780 6755 -25
===========================================
- Hits 44295 44293 -2
- Misses 8722 8737 +15
- Partials 2318 2319 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, thanks for the changes over room info!
2 questions :
- should we not make sure we call the
getUpdatedIsEncrypted
in theRoomFlowNode
? - Maybe we should keep the
EncryptionState.Unknown
in our layer? at least there are some places where we assert thatisEncrypted == encryptionState.ENCRYPTED
and so we can display wrong information (like the "room non encrypted" badge).
Edit : I've checked the rust PR and as far as I understand we can't get Unknown
anymore. If this is true, then forget my previous questions :P
…o` value This value will be used to make `MatrixRoom.roomInfoFlow` a `StateFlow` so we can assume the initial updated Room data will be present
a44c7c5
to
d7ee751
Compare
I've added some code to fetch the encryption state if it's still somehow unknown for some reason (I don't really know which SDK state could make this happen, but better safe than sorry). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, lets merge then!
Content
Changes:
v25.03.13
.MatrixRoom.isEncrypted
optional to take into account the unknown state, addedMatrixRoom.getUpdatedIsEncrypted()
to fetch the latest value.isEncrypted
async or default to considering itfalse
if no value is present.TracingInitializer
intoPlatformInitializer
, since it'll start not only the tracing service but also set up the amount of threads the SDK should use.Client::get_profile
orClient::get_notification_settings
).RoomInfo
, made sureRustMatrixRoom
always has an initial room info instance we can check.Motivation and context
Upgrading the SDK version was needed and there were lots of API changes.
Tests
Tested devices
Checklist