Skip to content

EC: Add PoC for native audio output selector #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jmartinesp
Copy link
Member

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp changed the title Add PoC for native audio output selector EC: Add PoC for native audio output selector Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/U99rgp

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 18.82353% with 138 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (5a2aeac) to head (94e37e0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...id/features/call/impl/utils/WebViewAudioManager.kt 16.66% 124 Missing and 1 partial ⚠️
...nt/android/features/call/impl/ui/CallScreenView.kt 54.54% 4 Missing and 1 partial ⚠️
...droid/features/call/impl/ui/ElementCallActivity.kt 0.00% 4 Missing ⚠️
...call/impl/utils/WebViewWidgetMessageInterceptor.kt 25.00% 3 Missing ⚠️
...x/impl/widget/DefaultCallWidgetSettingsProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4663      +/-   ##
===========================================
- Coverage    80.33%   80.19%   -0.15%     
===========================================
  Files         2135     2135              
  Lines        56431    56547     +116     
  Branches      7067     7107      +40     
===========================================
+ Hits         45336    45349      +13     
- Misses        8678     8782     +104     
+ Partials      2417     2416       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 5, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 5, 2025
@jmartinesp jmartinesp force-pushed the test/element-call-output-audio-selector-poc branch 2 times, most recently from 2ef71bf to 9ccfb63 Compare May 15, 2025 15:23
@jmartinesp jmartinesp force-pushed the test/element-call-output-audio-selector-poc branch from 640218b to ab7a555 Compare May 22, 2025 10:07
This way we can know when the EC page has been loaded and can start interacting with the JS code in it.
…anager` extension functions

This component is responsible of tracking the audio device usage on both the native OS and the webview and coordinating them.
@jmartinesp jmartinesp force-pushed the test/element-call-output-audio-selector-poc branch from 17621c2 to 94e37e0 Compare May 22, 2025 10:54
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant