-
Notifications
You must be signed in to change notification settings - Fork 226
Add support for login link #4752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ab54580
c02a294
3142791
2bf4573
7adacdc
dcda037
8dbcd68
faef90d
d36d85b
76786b9
8f209a8
3faa348
59a508f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright 2025 New Vector Ltd. | ||
* | ||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial | ||
* Please see LICENSE files in the repository root for full details. | ||
*/ | ||
|
||
package io.element.android.features.login.api | ||
|
||
interface LoginIntentResolver { | ||
fun parse(uriString: String): LoginParams? | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright 2025 New Vector Ltd. | ||
* | ||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial | ||
* Please see LICENSE files in the repository root for full details. | ||
*/ | ||
|
||
package io.element.android.features.login.api | ||
|
||
import android.os.Parcelable | ||
import kotlinx.parcelize.Parcelize | ||
|
||
/** | ||
* Parameters to start the login flow, when the application is opened | ||
* from a mobile.element.io link. | ||
*/ | ||
@Parcelize | ||
Check warning on line 17 in features/login/api/src/main/kotlin/io/element/android/features/login/api/LoginParams.kt
|
||
data class LoginParams( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add some docs for what these are used for? |
||
val accountProvider: String, | ||
val loginHint: String? | ||
) : Parcelable | ||
Check warning on line 21 in features/login/api/src/main/kotlin/io/element/android/features/login/api/LoginParams.kt
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to give some feedback to the user in this case, although I guess there's no easy way to display a dialog/toast from here 🫤 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. Showing a dialog is not in the flow. If one day we have multi account, we could be able to handle the link in all cases.