-
Notifications
You must be signed in to change notification settings - Fork 223
Fix left room membership change #4765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4765 +/- ##
===========================================
+ Coverage 80.33% 80.36% +0.02%
===========================================
Files 2135 2135
Lines 56431 56434 +3
Branches 7067 7068 +1
===========================================
+ Hits 45336 45352 +16
+ Misses 8678 8665 -13
Partials 2417 2417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ensureAllEventsConsumed() | ||
} | ||
rustBaseRoom.destroy() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create a private fun to avoid all the code duplication for those 3 tests?
Content
Ensure the right message is used when leaving room, according to the current membership :
Also add some tests to ensure the
room.leave
triggers the correct membership change.Motivation and context
Fix regression from removing RoomPreview
leave
usage.Because of this the message was always "Left room".
Screenshots / GIFs
No ui change.
Tests
Tested devices
Checklist