Stronger lambda error

[bmarty]

Content

Ensure that lambdaError() really breaks the test in all circumstances.
It can happen that the thrown Error is caught by the code, and this is not something expected.

Also there is a commit to harmonize how we create presenters to test them. I could have created a separate PR but this does not worth it I think.

Motivation and context

More accurate tests
Same code pattern for creating presenter under test.

Screenshots / GIFs

NA

Tests

• Run all tests, they should not fail

Tested devices

• NA

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yhu1sL

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (5b9da3c) to head (62ed92f).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4771   +/-   ##
========================================
  Coverage    80.40%   80.40%           
========================================
  Files         2143     2143           
  Lines        56766    56766           
  Branches      7119     7119           
========================================
  Hits         45644    45644           
  Misses        8685     8685           
  Partials      2437     2437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jmartinesp]

Just my 2 cents here, but I still think the right solution would be to replace runCatching/mapCatching usages with some version of ours that does not catch Error types or coroutine CancellationException. This would be more correct and it might even uncover some issues we might be not aware of in production and were ignored because we catch every possible throwable.

[bmarty]

@jmartinesp you're 💯 right and this is probably something we will do at some point. Can you create a new issue (task) with that? In the mean time, the idea of this "quick fix" is to avoid losing time when writing tests, which happened to me a few days ago.

[ganfra]

typo :

put a breakpoint

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud