-
Notifications
You must be signed in to change notification settings - Fork 226
fix(deps): update dependency org.matrix.rustcomponents:sdk-android to v25.5.26 #4781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency org.matrix.rustcomponents:sdk-android to v25.5.26 #4781
Conversation
- `RoomListItem` is gone, we should use `Room` now. - `SyncService.withUtdHook` has been replaced with `Client.setUtdDelegate`. - `ClientDelegate.didRefreshTokens` has been removed. It wasn't in use since a long time ago. - `TracingConfiguration` for the SDK now contains a `sentryDsn` parameter.
Adding an extra reviewer so they can check my changes. |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -212,6 +212,7 @@ class JoinedRustRoom( | |||
internalIdPrefix = internalIdPrefix, | |||
dateDividerMode = dateDividerMode, | |||
trackReadReceipts = trackReadReceipts, | |||
reportUtds = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we provide the analytics enabled state here? (if yes, can be done separately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe (should double check) this is relayed to the UnableToDecryptDelegate
, in our case UtdTracker
and we decide whether to upload them or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, probably, so this is fine!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4781 +/- ##
===========================================
- Coverage 80.41% 80.41% -0.01%
===========================================
Files 2144 2143 -1
Lines 56748 56745 -3
Branches 7112 7111 -1
===========================================
- Hits 45632 45629 -3
Misses 8684 8684
Partials 2432 2432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
25.5.21
->25.5.26
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.