Fix a bug where the view state is being modified during an update. (#…

…2686)
element-hq · Apr 12, 2024 · cc95c6a · cc95c6a
1 parent fc1310d
commit cc95c6a
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/ElementX/Sources/Other/SwiftUI/Layout/FullscreenDialog.swift b/ElementX/Sources/Other/SwiftUI/Layout/FullscreenDialog.swift
@@ -135,12 +135,21 @@ struct FullscreenDialog<Content: View, BottomContent: View>: View {
 
     func updateBackgroundVisibility(scrollView: UIScrollView) {
         guard dynamicTypeSize < .accessibility1 else {
-            showsBackground = true
+            if !showsBackground {
+                showsBackground = true
+            }
             return
         }
-        let insetHeight = scrollView.adjustedContentInset.top + scrollView.adjustedContentInset.bottom
-        let availableHeight = scrollView.frame.height - insetHeight
-        showsBackground = scrollView.contentSize.height < availableHeight
+
+        DispatchQueue.main.async { // Don't modify the state during a view update.
+            let insetHeight = scrollView.adjustedContentInset.top + scrollView.adjustedContentInset.bottom
+            let availableHeight = scrollView.frame.height - insetHeight
+            let shouldShowBackground = scrollView.contentSize.height < availableHeight
+
+            if showsBackground != shouldShowBackground {
+                showsBackground = shouldShowBackground
+            }
+        }
     }
 }