Don't group timeline items if more than 5 minutes has passed. (#4138)

pixlwave · web-flow · commit d76b76d04199 · 2025-05-21T10:34:22.000+01:00
Matches the behaviour on web.
diff --git a/ElementX/Sources/Screens/Timeline/TimelineViewModel.swift b/ElementX/Sources/Screens/Timeline/TimelineViewModel.swift
@@ -840,8 +840,9 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
             return false
         }
         
-        //  can be improved by adding a date threshold
-        return eventTimelineItem.properties.reactions.isEmpty && eventTimelineItem.sender == otherEventTimelineItem.sender
+        return eventTimelineItem.sender == otherEventTimelineItem.sender
+            && eventTimelineItem.properties.reactions.isEmpty // Reactions break the grouping.
+            && otherEventTimelineItem.timestamp.timeIntervalSince(eventTimelineItem.timestamp) < 5 * 60 // As does the passage of time.
     }
 
     // MARK: - Direct chats logics

Original file line number	Diff line number	Diff line change
`@@ -840,8 +840,9 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {`
`840`	`840`	`return false`
`841`	`841`	`}`
`842`	`842`
`843`		`- // can be improved by adding a date threshold`
`844`		`- return eventTimelineItem.properties.reactions.isEmpty && eventTimelineItem.sender == otherEventTimelineItem.sender`
	`843`	`+ return eventTimelineItem.sender == otherEventTimelineItem.sender`
	`844`	`+ && eventTimelineItem.properties.reactions.isEmpty // Reactions break the grouping.`
	`845`	`+ && otherEventTimelineItem.timestamp.timeIntervalSince(eventTimelineItem.timestamp) < 5 * 60 // As does the passage of time.`
`845`	`846`	`}`
`846`	`847`
`847`	`848`	`// MARK: - Direct chats logics`