Skip to content

Commit db6ed2e

Browse files
committed
a11y: accessibility labels for calls
1 parent 089d1fa commit db6ed2e

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

ElementX/Resources/Localizations/en-US.lproj/Localizable.strings

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"Notification" = "Notification";
22
"a11y_delete" = "Delete";
33
"a11y_hide_password" = "Hide password";
4+
"a11y_join_call" = "Join call";
45
"a11y_jump_to_bottom" = "Jump to bottom";
56
"a11y_notifications_mentions_only" = "Mentions only";
67
"a11y_notifications_muted" = "Muted";
@@ -9,6 +10,7 @@
910
"a11y_pin_field" = "PIN field";
1011
"a11y_play" = "Play";
1112
"a11y_poll_end" = "Ended poll";
13+
"a11y_profile_picture" = "Profile picture";
1214
"a11y_react_with" = "React with %1$@";
1315
"a11y_react_with_other_emojis" = "React with other emojis";
1416
"a11y_read_receipts_multiple" = "Read by %1$@ and %2$@";

ElementX/Resources/Localizations/en.lproj/Localizable.strings

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"Notification" = "Notification";
22
"a11y_delete" = "Delete";
33
"a11y_hide_password" = "Hide password";
4+
"a11y_join_call" = "Join call";
45
"a11y_jump_to_bottom" = "Jump to bottom";
56
"a11y_notifications_mentions_only" = "Mentions only";
67
"a11y_notifications_muted" = "Muted";
@@ -9,6 +10,7 @@
910
"a11y_pin_field" = "PIN field";
1011
"a11y_play" = "Play";
1112
"a11y_poll_end" = "Ended poll";
13+
"a11y_profile_picture" = "Profile picture";
1214
"a11y_react_with" = "React with %1$@";
1315
"a11y_react_with_other_emojis" = "React with other emojis";
1416
"a11y_read_receipts_multiple" = "Read by %1$@ and %2$@";

ElementX/Sources/Generated/Strings.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ internal enum L10n {
1818
}
1919
/// Hide password
2020
internal static var a11yHidePassword: String { return L10n.tr("Localizable", "a11y_hide_password") }
21+
/// Join call
22+
internal static var a11yJoinCall: String { return L10n.tr("Localizable", "a11y_join_call") }
2123
/// Jump to bottom
2224
internal static var a11yJumpToBottom: String { return L10n.tr("Localizable", "a11y_jump_to_bottom") }
2325
/// Mentions only
@@ -38,6 +40,8 @@ internal enum L10n {
3840
internal static var a11yPoll: String { return L10n.tr("Localizable", "a11y_poll") }
3941
/// Ended poll
4042
internal static var a11yPollEnd: String { return L10n.tr("Localizable", "a11y_poll_end") }
43+
/// Profile picture
44+
internal static var a11yProfilePicture: String { return L10n.tr("Localizable", "a11y_profile_picture") }
4145
/// React with %1$@
4246
internal static func a11yReactWith(_ p1: Any) -> String {
4347
return L10n.tr("Localizable", "a11y_react_with", String(describing: p1))

ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,15 @@ struct RoomScreen: View {
233233
.labelStyle(.titleAndIcon)
234234
}
235235
.buttonStyle(ElementCallButtonStyle())
236+
.accessibilityLabel(L10n.a11yJoinCall)
236237
.accessibilityIdentifier(A11yIdentifiers.roomScreen.joinCall)
237238
} else {
238239
Button {
239240
roomContext.send(viewAction: .displayCall)
240241
} label: {
241242
CompoundIcon(\.videoCallSolid)
242243
}
244+
.accessibilityLabel(L10n.a11yStartCall)
243245
.accessibilityIdentifier(A11yIdentifiers.roomScreen.joinCall)
244246
}
245247
}

0 commit comments

Comments
 (0)