-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to accept or decline invites without MSC3266 enabled #3713
Comments
EX heavily depends on the Room Summary API. It is mandatory to have it enabled on Synapse. |
Hi @manuroe, Element X Android does not require this API or at least does not fail catastrophically when it is disabled. This is an issue specific to Element X iOS. Furthermore, I don't see why the Room Summary API should be mandatory for accepting invites. I understand why it is useful for richer rendering of invites in the room list, but I don't understand how it is relevant after the user has already chosen to accept or decline. In any case, seeing as the Room Summary API is not yet part of the spec, reliant on an unstable prefix, and not enabled by default in Synapse, may I ask if it is documented somewhere that it is required for Element X iOS? If there are any other unstable APIs required for Element X iOS (or Android), I would like to know about those as well. |
Which of the screens are we actually talking about here? I see http preview failures in your logs but can't the user accept the invite from the room list? |
Hi @stefanceriu, The user cannot accept or decline the invite if MSC3266 is disabled. The provided logs are from after the user taps the accept button, which is why I was not sure why the Room Summary API is being called here at all. I have not tested how Element X iOS or Element X Android behave when tapping on the invite for more info. This issue is strictly about the action of accepting or declining an invite failing catastrophically. |
Well I can see two possibilities:
|
Hi @stefanceriu, I tested this myself on both platforms before opening an issue. The logs are generated and retrieved by me, not by anyone else. I know for certain that I tapped squarely on the Accept/Decline buttons, and I reproduced the described behavior several times on both platforms and with MSC3266 both enabled and disabled. After tapping "Accept", Element X iOS If I have a chance I will do some more testing to reconfirm everything. |
Hi @stefanceriu, I have retested the behavior on both platforms when MSC3266 is disabled: Element X iOSTapping "Accept" or "Decline" from the room list directly brings up the "Sorry, an error occurred" popup. There is no change in screens as I incorrectly stated earlier. Tapping the invite outside the action buttons brings up the preview screen, which says "Preview is not available" (as shown below) but does not fail catastrophically. The preview screen, however, is the version used for joining public rooms from the room directory ("Join room" button) rather than the correct version for invites ("Decline"/"Accept" buttons). From the preview, incorrect as it may be, tapping "Join room" does successfully join the room with no visible error message. Element X AndroidTapping "Accept" from the room list successfully joins the room and brings up the timeline for the room. Tapping "Decline" from the room list brings up a confirmation prompt. Tapping "Decline" again in the confirmation prompt does nothing and fails silently. This is contrary to my previous assumption that Element X Android is perfectly functional even with MSC3266 disabled, and I will open a separate bug report in the Element X Android repo for this. Tapping the invite outside the action buttons brings up the preview screen, which correctly displays the room title and inviter (as shown below). Tapping "Accept" or "Decline" from the preview has the exact same behavior as the respective action buttons in the room list. Preview UIs
It should be noted that Element X iOS correctly displays the room title and inviter in the room list even when MSC3266 is disabled. The Room Summary API is not required to fetch this data for invitations. |
Steps to reproduce
experimental.msc3266_enabled
is set to false in Synapse configuration (the default)Outcome
What did you expect?
Successfully joining the room
What happened instead?
"Sorry, an error occurred"
Your phone model
iPhone 16
Operating system version
iOS 18.2.1
Application version
Version 1.9.9 (140)
Homeserver
Synapse 1.122.0
Logs
The text was updated successfully, but these errors were encountered: