Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various integration test tweaks following test homeserver and account… #2317

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

stefanceriu
Copy link
Member

… change

Switches the integration tests to matrix.org and the big tests account and tweaks certain steps to make them more reliable.

Test run here https://github.com/element-hq/element-x-ios/actions/runs/7474683118

@stefanceriu stefanceriu requested a review from a team as a code owner January 10, 2024 13:42
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team January 10, 2024 13:42
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 47a921e

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dfc0be) 72.16% compared to head (47a921e) 72.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2317      +/-   ##
===========================================
+ Coverage    72.16%   72.85%   +0.68%     
===========================================
  Files          511      511              
  Lines        35309    35309              
  Branches     16988    16988              
===========================================
+ Hits         25481    25723     +242     
+ Misses        9200     8962     -238     
+ Partials       628      624       -4     
Flag Coverage Δ
integrationtests 36.25% <ø> (+2.00%) ⬆️
unittests 57.86% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, they're finally running again! 👏👏👏

@stefanceriu stefanceriu merged commit cf7e09e into develop Jan 10, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/integrationTestFixes branch January 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants