-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateMembers now is chain of membersNoSync + membersWithSync #2324
Conversation
Generated by 🚫 Danger Swift against 9fed7f5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2324 +/- ##
===========================================
- Coverage 72.18% 72.10% -0.08%
===========================================
Files 511 511
Lines 35319 35319
Branches 16990 16990
===========================================
- Hits 25496 25468 -28
- Misses 9195 9227 +32
+ Partials 628 624 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
fixes #2304
This will make the loading of members be faster if the members have already been stored locally.
This PR also updates the SDK and renames some variables and functions related to an API name change in the SDK