Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateMembers now is chain of membersNoSync + membersWithSync #2324

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 11, 2024

fixes #2304

This will make the loading of members be faster if the members have already been stored locally.
This PR also updates the SDK and renames some variables and functions related to an API name change in the SDK

@Velin92 Velin92 requested a review from a team as a code owner January 11, 2024 15:56
@Velin92 Velin92 requested review from pixlwave and removed request for a team January 11, 2024 15:56
Copy link

github-actions bot commented Jan 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9fed7f5

@Velin92 Velin92 requested a review from stefanceriu January 11, 2024 16:11
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21fa5d1) 72.18% compared to head (9fed7f5) 72.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2324      +/-   ##
===========================================
- Coverage    72.18%   72.10%   -0.08%     
===========================================
  Files          511      511              
  Lines        35319    35319              
  Branches     16990    16990              
===========================================
- Hits         25496    25468      -28     
- Misses        9195     9227      +32     
+ Partials       628      624       -4     
Flag Coverage Δ
unittests 57.98% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit e51e2ac into develop Jan 12, 2024
8 checks passed
@Velin92 Velin92 deleted the mauroromito/update_members_improvement branch January 12, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read receipt avatars don't load reliably
2 participants