Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AttributedStringBuilderComponent identifiers, fix layout issues #2326

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jan 12, 2024

Fixes #2322

@stefanceriu stefanceriu requested a review from a team as a code owner January 12, 2024 06:52
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 12, 2024 06:52
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6ebfb12

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21fa5d1) 72.64% compared to head (6ebfb12) 72.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2326      +/-   ##
===========================================
- Coverage    72.64%   72.64%   -0.01%     
===========================================
  Files          511      511              
  Lines        35319    35312       -7     
  Branches     16990    16990              
===========================================
- Hits         25657    25651       -6     
- Misses        9034     9035       +1     
+ Partials       628      626       -2     
Flag Coverage Δ
unittests 58.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 2d66e76 into develop Jan 12, 2024
8 checks passed
@stefanceriu stefanceriu deleted the stefan/attributedStringBuilderComponentsLayout branch January 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions layout has regressed
2 participants