Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription fixes #2351

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Subscription fixes #2351

merged 3 commits into from
Jan 17, 2024

Conversation

stefanceriu
Copy link
Member

Makes room proxy unsubscriptions explicit. Fixes problems in which creating and deallocating room proxies would unexpectedly unsubscribe other proxies.

@stefanceriu stefanceriu requested a review from a team as a code owner January 17, 2024 09:47
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 17, 2024 09:47
Copy link

github-actions bot commented Jan 17, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 5cc897d

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6ed5b74) 73.08% compared to head (6113f98) 73.18%.
Report is 1 commits behind head on develop.

❗ Current head 6113f98 differs from pull request most recent head 5cc897d. Consider uploading reports for the commit 5cc897d to get more accurate results

Files Patch % Lines
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2351      +/-   ##
===========================================
+ Coverage    73.08%   73.18%   +0.09%     
===========================================
  Files          513      513              
  Lines        35362    35357       -5     
  Branches     16993    16994       +1     
===========================================
+ Hits         25846    25875      +29     
+ Misses        8892     8855      -37     
- Partials       624      627       +3     
Flag Coverage Δ
unittests 57.94% <60.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/subscriptionFixes branch from 55bcc0a to 84fb64f Compare January 17, 2024 10:36
@stefanceriu stefanceriu force-pushed the stefan/subscriptionFixes branch from 84fb64f to 6113f98 Compare January 17, 2024 10:36
@stefanceriu stefanceriu enabled auto-merge (rebase) January 17, 2024 10:36
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 9bb9c8b into develop Jan 17, 2024
4 checks passed
@stefanceriu stefanceriu deleted the stefan/subscriptionFixes branch January 17, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants