-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription fixes #2351
Subscription fixes #2351
Conversation
Generated by 🚫 Danger Swift against 5cc897d |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2351 +/- ##
===========================================
+ Coverage 73.08% 73.18% +0.09%
===========================================
Files 513 513
Lines 35362 35357 -5
Branches 16993 16994 +1
===========================================
+ Hits 25846 25875 +29
+ Misses 8892 8855 -37
- Partials 624 627 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
55bcc0a
to
84fb64f
Compare
…ating and deallocating room proxies would unexpectedly unsubscribe other proxies.
84fb64f
to
6113f98
Compare
|
Makes room proxy unsubscriptions explicit. Fixes problems in which creating and deallocating room proxies would unexpectedly unsubscribe other proxies.