Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen rotation for the camera #2353

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 17, 2024

fixes #1815

RPReplay_Final1705508394.MP4

@Velin92 Velin92 requested a review from a team as a code owner January 17, 2024 16:16
@Velin92 Velin92 requested review from pixlwave and stefanceriu and removed request for a team January 17, 2024 16:16
Copy link

github-actions bot commented Jan 17, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 83606c3

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (65e9c3b) 72.89% compared to head (fd875ca) 72.80%.

❗ Current head fd875ca differs from pull request most recent head 83606c3. Consider uploading reports for the commit 83606c3 to get more accurate results

Files Patch % Lines
...diaPickerScreen/MediaPickerScreenCoordinator.swift 0.00% 18 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 16.66% 10 Missing ⚠️
.../Sources/Application/Windowing/WindowManager.swift 40.00% 6 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 5 Missing ⚠️
...sEditScreen/RoomDetailsEditScreenCoordinator.swift 0.00% 3 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 2 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 1 Missing ⚠️
ElementX/Sources/Application/Application.swift 50.00% 1 Missing ⚠️
...sEditScreen/UserDetailsEditScreenCoordinator.swift 0.00% 1 Missing ⚠️
...s/StartChatScreen/StartChatScreenCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2353      +/-   ##
===========================================
- Coverage    72.89%   72.80%   -0.09%     
===========================================
  Files          513      513              
  Lines        35357    35395      +38     
  Branches     16994    17007      +13     
===========================================
- Hits         25772    25769       -3     
- Misses        8968     9010      +42     
+ Partials       617      616       -1     
Flag Coverage Δ
unittests 57.84% <18.64%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Just a few small comments inline..

@Velin92 Velin92 requested a review from stefanceriu January 18, 2024 12:45
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 enabled auto-merge (squash) January 18, 2024 13:05
@Velin92 Velin92 merged commit 3ae33f1 into develop Jan 18, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/lock_camera_screen_rotation branch January 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to take photo in landscape mode
2 participants