-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock screen rotation for the camera #2353
Conversation
Generated by 🚫 Danger Swift against 83606c3 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2353 +/- ##
===========================================
- Coverage 72.89% 72.80% -0.09%
===========================================
Files 513 513
Lines 35357 35395 +38
Branches 16994 17007 +13
===========================================
- Hits 25772 25769 -3
- Misses 8968 9010 +42
+ Partials 617 616 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍 Just a few small comments inline..
ElementX/Sources/Application/Windowing/WindowManagerProtocol.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/MediaPickerScreen/MediaPickerScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
|
fixes #1815
RPReplay_Final1705508394.MP4