-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for quick room search through the Cmd+K shortcut #2363
Conversation
Generated by 🚫 Danger Swift against 180f21c |
058f770
to
b85ff1f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2363 +/- ##
===========================================
- Coverage 73.45% 73.13% -0.33%
===========================================
Files 517 522 +5
Lines 35831 36200 +369
Branches 17233 17401 +168
===========================================
+ Hits 26319 26474 +155
- Misses 8870 9088 +218
+ Partials 642 638 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👏
I think there's a few things that need changing architecture wise, otherwise just minor comments
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/View/GlobalSearchScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/View/GlobalSearchScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/View/GlobalSearchScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/View/GlobalSearchScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/View/GlobalSearchScreenCell.swift
Show resolved
Hide resolved
b85ff1f
to
ceeae0e
Compare
e89cb29
to
05b292d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok LGTM, with that 1 comment above.
05b292d
to
98049cb
Compare
98049cb
to
180f21c
Compare
|
This PR leverages the new WindowManager, existing room list filtering and UI to implement a quick room search window that appears on Cmd+k and has full keyboard support for both the Mac and iPad OS (whenever a hardware keyboard is connected).
Goes hand in hand with #2343 to make finding, opening and starting typing in a room a breeze.
GlobalSearch.mp4