Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quick room search through the Cmd+K shortcut #2363

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

stefanceriu
Copy link
Member

This PR leverages the new WindowManager, existing room list filtering and UI to implement a quick room search window that appears on Cmd+k and has full keyboard support for both the Mac and iPad OS (whenever a hardware keyboard is connected).

Goes hand in hand with #2343 to make finding, opening and starting typing in a room a breeze.

GlobalSearch.mp4

@stefanceriu stefanceriu requested a review from a team as a code owner January 20, 2024 15:36
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team January 20, 2024 15:36
Copy link

github-actions bot commented Jan 20, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 180f21c

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 185 lines in your changes are missing coverage. Please review.

Comparison is base (d911e4f) 73.45% compared to head (98049cb) 73.13%.
Report is 1 commits behind head on develop.

❗ Current head 98049cb differs from pull request most recent head 180f21c. Consider uploading reports for the commit 180f21c to get more accurate results

Files Patch % Lines
...s/GlobalSearchScreen/View/GlobalSearchScreen.swift 52.90% 72 Missing and 1 partial ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 39 Missing ⚠️
.../Sources/Application/Windowing/WindowManager.swift 13.51% 32 Missing ⚠️
...alSearchScreen/GlobalSearchScreenCoordinator.swift 0.00% 26 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 3 Missing ⚠️
...obalSearchScreen/GlobalSearchScreenViewModel.swift 95.45% 3 Missing ⚠️
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 0.00% 2 Missing ⚠️
...es/Screens/HomeScreen/View/HomeScreenContent.swift 66.66% 2 Missing ⚠️
...en/RoomNotificationSettingsScreenCoordinator.swift 0.00% 2 Missing ⚠️
ElementX/Sources/Other/AvatarSize.swift 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2363      +/-   ##
===========================================
- Coverage    73.45%   73.13%   -0.33%     
===========================================
  Files          517      522       +5     
  Lines        35831    36200     +369     
  Branches     17233    17401     +168     
===========================================
+ Hits         26319    26474     +155     
- Misses        8870     9088     +218     
+ Partials       642      638       -4     
Flag Coverage Δ
unittests 57.69% <51.05%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏

I think there's a few things that need changing architecture wise, otherwise just minor comments

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM, with that 1 comment above.

@stefanceriu stefanceriu enabled auto-merge (squash) January 29, 2024 11:21
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu disabled auto-merge January 29, 2024 12:54
@stefanceriu stefanceriu merged commit 197b088 into develop Jan 29, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the stefan/globalSearch branch January 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants