Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an app log viewer #2369

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add an app log viewer #2369

merged 2 commits into from
Jan 23, 2024

Conversation

stefanceriu
Copy link
Member

Logs can now be viewed from the report a problem screen.

Simulator.Screen.Recording.-.iPhone.14.Plus.iOS.16.4.-.2024-01-22.at.18.19.54.mp4

@stefanceriu stefanceriu requested a review from a team as a code owner January 22, 2024 16:22
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team January 22, 2024 16:22
Copy link

github-actions bot commented Jan 22, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 882ebf5

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ate flow coordinator. Reuse it as a child coordinator in the authentication, userSessionFlow and settings flow coordinators.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 219 lines in your changes are missing coverage. Please review.

Comparison is base (faeab89) 73.19% compared to head (882ebf5) 72.81%.
Report is 3 commits behind head on develop.

Files Patch % Lines
...es/FlowCoordinators/BugReportFlowCoordinator.swift 0.00% 80 Missing ⚠️
...Screens/LogViewerScreen/View/LogViewerScreen.swift 0.00% 36 Missing ⚠️
...s/LogViewerScreen/LogViewerScreenCoordinator.swift 0.00% 25 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 17 Missing ⚠️
...ens/LogViewerScreen/LogViewerScreenViewModel.swift 0.00% 15 Missing ⚠️
...ens/Authentication/AuthenticationCoordinator.swift 0.00% 13 Missing ⚠️
...s/BugReportScreen/BugReportScreenCoordinator.swift 0.00% 13 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 6 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 3 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2369      +/-   ##
===========================================
- Coverage    73.19%   72.81%   -0.39%     
===========================================
  Files          513      517       +4     
  Lines        35413    35583     +170     
  Branches     17016    17104      +88     
===========================================
- Hits         25922    25911      -11     
- Misses        8866     9049     +183     
+ Partials       625      623       -2     
Flag Coverage Δ
unittests 57.68% <6.41%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 31286c7 into develop Jan 23, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/logsViewer branch January 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants