-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notification setting to hide unread messages badges. #2412
Conversation
Generated by 🚫 Danger Swift against 2374b91 |
🥇 Sanity mode :'D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah would probably refactor HomeScreenRoom at this point to include the view logic directly
b1cd076
to
1bce84a
Compare
1bce84a
to
2374b91
Compare
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2412 +/- ##
========================================
Coverage 72.99% 72.99%
========================================
Files 523 523
Lines 36191 36239 +48
Branches 17413 17423 +10
========================================
+ Hits 26417 26453 +36
- Misses 9135 9143 +8
- Partials 639 643 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adds a setting that allows users to focus more by hiding grey unread dots on rooms that are set to only notify for mentions & keywords or not at all. Current strings are a placeholder, this PR isn't ready to merge until they've been added to Localazy.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.12.26.59.mp4