Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notification setting to hide unread messages badges. #2412

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 1, 2024

Adds a setting that allows users to focus more by hiding grey unread dots on rooms that are set to only notify for mentions & keywords or not at all. Current strings are a placeholder, this PR isn't ready to merge until they've been added to Localazy.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.12.26.59.mp4

@pixlwave pixlwave requested a review from a team as a code owner February 1, 2024 12:33
@pixlwave pixlwave requested review from Velin92 and amshakal and removed request for a team February 1, 2024 12:33
Copy link

github-actions bot commented Feb 1, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 2374b91

@amshakal
Copy link

amshakal commented Feb 1, 2024

🥇 Sanity mode :'D

@pixlwave pixlwave changed the title Add a notification setting to unread messages badges. Add a notification setting to hide unread messages badges. Feb 1, 2024
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah would probably refactor HomeScreenRoom at this point to include the view logic directly

@pixlwave pixlwave force-pushed the doug/unread-badge-toggle branch 2 times, most recently from b1cd076 to 1bce84a Compare February 5, 2024 18:29
@pixlwave pixlwave requested a review from Velin92 February 5, 2024 18:29
@pixlwave pixlwave mentioned this pull request Feb 6, 2024
@pixlwave pixlwave force-pushed the doug/unread-badge-toggle branch from 1bce84a to 2374b91 Compare February 7, 2024 12:19
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (f9edb75) 72.99% compared to head (2374b91) 72.99%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 67.34% 16 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 29.41% 12 Missing ⚠️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 0.00% 6 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 93.93% 4 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 4 Missing ⚠️
...rListScreen/RoomMembersListScreenCoordinator.swift 0.00% 3 Missing ⚠️
...berListScreen/RoomMembersListScreenViewModel.swift 62.50% 3 Missing ⚠️
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 92.00% 0 Missing and 2 partials ⚠️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 75.00% 2 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2412   +/-   ##
========================================
  Coverage    72.99%   72.99%           
========================================
  Files          523      523           
  Lines        36191    36239   +48     
  Branches     17413    17423   +10     
========================================
+ Hits         26417    26453   +36     
- Misses        9135     9143    +8     
- Partials       639      643    +4     
Flag Coverage Δ
unittests 58.18% <72.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit d0c835a into develop Feb 7, 2024
5 checks passed
@pixlwave pixlwave deleted the doug/unread-badge-toggle branch February 7, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants